Mass flow, specific energy and some new units #116
Conversation
|
Sorry for the delay. Made changes according to your comments. I'll add some comments/questions to the commit. |
|
Abbreviations min and sec ahould be fine as it does not conflict with any other Angle units. It is mainly for Angle.Parse() and .ToString () these are used. ToString () uses the first one in the list. |
|
This looks good to me at first glance. Browsing on the phone. |
There was a problem hiding this comment.
This change should be omitted.
|
I've gone through the entire diff now, if you go over these this should be ready to merge in. |
|
On a side note, I recommend doing smaller pull requests, such as one per class of units. This way I'll be able to merge in the good parts faster. |
|
Fixed the project file and the inverted conversion in MassFlow, couldn't find more errors (using Google to check was certainly easier than doing it manually). We will try to do smaller pull requests in the future. We (mainly @ulflind ) have been working with the overloading without code generation (see discussion in #113), that will be quite big too I'm afraid. |
|
Looks good. Thanks! |
Mass flow, specific energy and some new units
|
Nuget 3.22.0 out. |
3 participants
Added mass flow and the following units:
Radians per second
Nautical miles
Knots
Meters per hour
Second of arc
Minute of arc