Feature/add rotational speed with correction #123
Conversation
Tests do not pass
Change base unit to radian per second because of loss of precision (tests were red). Add prefixes for radian per second.
|
This looks good to me, the only concern is changing the base unit. This has not been done before and it could potentially break backwards compatibility with serialization, but I don't believe it should in practice at least not for the Json serialization in this repo, since it serializes both value and unit. Can you think of any other scenario? If not I'll merge this in. |
|
After some thought I am fine with changing the base unit, and realized we have in fact done similar before. Units.NET does not guarantee this will not change and this is mentioned in the README section on serialization. I'll add a text to the README explicitly stating that the base unit may change and should not be used for serialization. |
…peed_WithCorrection Add RotationalSpeed units
|
Yes, at the time I wasn't too happy either to change the base unit, but thought that precision is important and tests were green. I agree that serializing both value and unit will avoid any trouble with change base units. |
2 participants
No description provided.