-
Notifications
You must be signed in to change notification settings - Fork 401
Feature/operator overloading #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/operator overloading #124
Conversation
Conflicts: UnitsNet.Tests/CustomCode/LengthTests.cs UnitsNet.Tests/CustomCode/SpeedTests.cs
Conflicts: UnitsNet.Tests/CustomCode/AngleTests.cs UnitsNet.Tests/CustomCode/MassFlowTests.cs UnitsNet.Tests/CustomCode/RotationalSpeedTests.cs
Thanks, I will try to take a look at this soon. A bit occupied with selling my house these days. |
No problem. Good luck with selling the house. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, SpeedDividedBy.
Typo, TimeSpanTimesSpeed
What a massive piece of work, great job. I'm awaiting your feedback on my comments, then let me know when you think it is ready for merge and I'll take a final look at it. Future improvement
This one is tricky, should we preserve .NET round behavior so that |
It should be ready to merge now (see comments on your comment, typos should be fixed).
|
You are right of course, I forgot we already had some operator overloads. |
Add operator overloads of the most common unit conversions
Nuget 3.25 out. |
Operator overloading as discussed in #89 and #113.
We've added the most common operations and the ones we know we will use. It is probably easiest to add more overloads when they are needed.
All code is cross-checked twice by me and @ulflind but I wouldn't be surprised if you find something that needs fixing.