-
Notifications
You must be signed in to change notification settings - Fork 400
Handle ambiguous abbreviation parsing by throwing exception #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle ambiguous abbreviation parsing by throwing exception #140
Conversation
…eption + tidyup
Conflicts: UnitsNet/Scripts/UnitDefinitions/Volume.json
This should be good now - I haven't placed all abbreviations onto the units yet - just noticed you were busy reformatting all json files ;) |
Throw exception when parsing ambiguous abbreviation
Sweet, looks good to me. |
Nuget 3.26 is now out. I'm curious, did you get notified when I mentioned you in the github release? |
Awesome - thank you. |
Ok good to know, I've always wondered the best way to notify contributors of a new release. Was hoping tagging in the release notes would do it, but guess not. |
If it helps, personally, I don't need the notification as I can see you release quickly after a merge so I just keep an eye out. On other library projects I have a personal myget feed that builds from my fork and I use that until the PR becomes official. Your fast releases and the nature of the library - not needing dogfooding before PR - save me that extra work. It does give you more work though in manually balling up a release though, so you could automatically release on merge via nuget/teamcity. You lose the custom change log in the nuspec but it saves you from the manual work and contributors know a merge = a release. Just food for thought! |
Thanks for the input. I did have the nuget publish automated in TeamCity a while back, but after changing branch style from gitflow back to github flow I didn't bother fixing it. It really is just bumping the .nuspec version and running two bat files to deploy, so the effort and frequency are too low to make me want to spend time automating it again. I do want to keep a changelog though, so I'm thinking instead of putting it in the .nuspec, maybe just add it as annotation to the git tags instead. That should make it available on github too. |
As discussed on #132, this PR supports having abbreviations shared across units and throws when ambiguous.
I'll add some notes to the diff