Skip to content

Conversation

neutmute
Copy link
Contributor

As discussed on #132, this PR supports having abbreviations shared across units and throws when ambiguous.

I'll add some notes to the diff

@neutmute neutmute changed the title #132 Handle ambiguous abbreviation parsing by throwing exception Handle ambiguous abbreviation parsing by throwing exception Feb 16, 2016
@neutmute
Copy link
Contributor Author

This should be good now - I haven't placed all abbreviations onto the units yet - just noticed you were busy reformatting all json files ;)

angularsen added a commit that referenced this pull request Feb 17, 2016
Throw exception when parsing ambiguous abbreviation
@angularsen angularsen merged commit 37a9c48 into angularsen:master Feb 17, 2016
@angularsen
Copy link
Owner

Sweet, looks good to me.

@angularsen
Copy link
Owner

Nuget 3.26 is now out.

I'm curious, did you get notified when I mentioned you in the github release?
https://github.com/anjdreas/UnitsNet/releases

@neutmute
Copy link
Contributor Author

Awesome - thank you.
Checking my emails - no, I only received notifications from your comments - not the release notes.

@neutmute neutmute deleted the feature/ambiguous-abbreviations branch February 19, 2016 23:38
@angularsen
Copy link
Owner

Ok good to know, I've always wondered the best way to notify contributors of a new release. Was hoping tagging in the release notes would do it, but guess not.

@neutmute
Copy link
Contributor Author

If it helps, personally, I don't need the notification as I can see you release quickly after a merge so I just keep an eye out. On other library projects I have a personal myget feed that builds from my fork and I use that until the PR becomes official. Your fast releases and the nature of the library - not needing dogfooding before PR - save me that extra work.

It does give you more work though in manually balling up a release though, so you could automatically release on merge via nuget/teamcity. You lose the custom change log in the nuspec but it saves you from the manual work and contributors know a merge = a release.
If you want to bundle a few merges, perhaps have the default branch as develop with merges going into develop. A manual merge by yourself to master would trigger the CI build and release to nuget.

Just food for thought!

@angularsen
Copy link
Owner

Thanks for the input. I did have the nuget publish automated in TeamCity a while back, but after changing branch style from gitflow back to github flow I didn't bother fixing it. It really is just bumping the .nuspec version and running two bat files to deploy, so the effort and frequency are too low to make me want to spend time automating it again.

I do want to keep a changelog though, so I'm thinking instead of putting it in the .nuspec, maybe just add it as annotation to the git tags instead. That should make it available on github too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants