Skip to content

Conversation

rdelhommer
Copy link
Contributor

No description provided.

@rdelhommer
Copy link
Contributor Author

Also, I noticed that some code not related to my volume changes was regenerated. The changes looked to be associated with pull request 141. As it involved changing the Angle, Flow, RotationalSpeed, and ForceChangeRate units in some static methods to nullables. I didn't include the non-volume generated code, but it might be something that was missed in 141.

@eriove
Copy link
Contributor

eriove commented Mar 1, 2016

Hmm, I added the nullable "constructors" in #141. But I forgot to rebase and regenerate before committing. Will create a new PR.

Edit: New pull PR done ( #149 )

@angularsen
Copy link
Owner

@eriove @rdelhommer
My mistake guys. I should add a build step to regenerated code before building and releasing a nuget, to be sure it's running all recent changes. I will merge both of these and make doubly sure this time.

angularsen added a commit that referenced this pull request Mar 2, 2016
Add Microliter unit and add Russian abbreviations
@angularsen angularsen merged commit 8d2f5d1 into angularsen:master Mar 2, 2016
@angularsen
Copy link
Owner

Nuget 3.28.1 out, plus I made sure to avoid this mistake in the future by updating the build script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants