Replace all occurences of the Greek lower case letter 'mu' with the c… #224
Conversation
…orrect unicode Micro symbol. Add tests to ensure all units that use the Micro scale are using the correct unicode character.
… greek letter 'mu' with the correct Micro sign character.
|
What exactly is this build message telling me? |
There was a problem hiding this comment.
So, I don't really see anything wrong here. JSON and PS1 files updated, you regenerated the code. As far as I can tell it's all there, but I'll need some time to look into this more.
From the build server, this a recurring error:
[07:00:22][Step 1/1] UnitSystemTests.cs(290,27): error CS0122: 'UnitsNetException' is inaccessible due to its protection level [C:\TeamCity\buildAgent\work\6c2ac6daa7a037ba\UnitsNet.Tests\UnitsNet.WindowsRuntimeComponent.Tests.csproj]
| } | ||
|
|
||
| [Test] | ||
| public void ShouldUseCorrectMicroSign() |
There was a problem hiding this comment.
Nice set of tests this, even though it will get out of date at some point it is a nice sanity check.
There was a problem hiding this comment.
Yea, it would have been ideal to tap into the code generation and have this test generated for each unit that uses the Micro symbol. The amount I have to contribute to this is dictated by the return on investment for my client though...so that extra level didn't quite make the cut (yet) unfortunately.
|
Just a notice that I have a severe case of the manflu and might need some extra time to respond the next few days. As for the message, my reverse proxy to make the TeamCity build server available on the Internet broke, so you won't be able to access it. |
|
I found the problem, the UnitsNetException type is internal in WINDOWS_UWP profile (Windows Runtime Component target). I added an assembly attribute to make it visible to tests. |
|
For your reference: d2f0c08 |
2 participants
…orrect unicode Micro symbol.
Add tests to ensure all units that use the Micro scale are using the correct unicode character.