Skip to content

Conversation

eriove
Copy link
Contributor

@eriove eriove commented Jul 27, 2017

The CLS compliant got dropped when switching project format, see #128 for background.

This adds it back

@angularsen angularsen merged commit 3925229 into angularsen:master Jul 27, 2017
@eriove
Copy link
Contributor Author

eriove commented Jul 27, 2017

Thanks, that was fast!

@eriove eriove deleted the feature/clscompliant branch July 27, 2017 12:28
@angularsen
Copy link
Owner

angularsen commented Jul 27, 2017

Thanks for spotting and fixing!

You have been quite active on this project and providing quality commits and discussions, which I appreciate a lot.

Would you be interested in joining as a collaborator?

I sometimes struggle to find the time and it would be good to have some extra pair of hands to ensure the library continues to evolve and improve. @JKSnd is the only other collaborator today.

Edit: Your involvement is up to you, but at least reviewing PRs and issues is something that is immediately helpful. You will also be able to modify the project directly, although bigger changes is always nice to discuss via a PR upfront.

@angularsen
Copy link
Owner

Nuget 3.67 on the way.

@eriove
Copy link
Contributor Author

eriove commented Jul 31, 2017

@anjdreas Sorry, mean to answer earlier and left the reply in the browser without pressing "comment".

I'd be happy to review PRs and issues, but just be aware that I don't have that much time either.

@angularsen
Copy link
Owner

Great! I'll sign you up then. I don't expect much of your time and no obligations. Feel free to take on the review of any issue or PR by marking yourself as Assigned. I may also call out for help if I want to discuss something or if a PR needs attention and I don't find the time myself.

Ok by you?

@eriove
Copy link
Contributor Author

eriove commented Jul 31, 2017

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants