changed expressions in term of algebraic operations with corresponding numeric results #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g numeric results
angularsen
requested changes
Nov 19, 2017
| @@ -27,9 +27,9 @@ public class SpecificEnergyTests : SpecificEnergyTestsBase | |||
| { | |||
| protected override double JoulesPerKilogramInOneJoulePerKilogram => 1.0; | |||
|
|
|||
| protected override double CaloriesPerGramInOneJoulePerKilogram => 1.0/4.184E3; | |||
| protected override double CaloriesPerGramInOneJoulePerKilogram => 2.410800386e-4; | |||
There was a problem hiding this comment.
Computing this value gives me: 0.00023900573
Was the function not correct to begin with or is this IT vs th calories?
In retrospect, we maybe should have named the units CaloriesIt and CaloiresTh to disambiguate them.
There was a problem hiding this comment.
Looks like he divided with 4148 instead of 4184. I'm fixing this now.
And perhaps we should either say in README that we don't support IT's but only TH's, or we should name them as you said.
|
|
||
| protected override double KilocaloriesPerGramInOneJoulePerKilogram => 1.0/4.184E6; | ||
| protected override double KilocaloriesPerGramInOneJoulePerKilogram => 2.410800386e-7; |
added 4 commits
November 20, 2017 16:37
watt, kilowatt and megawatt tests should have the same number of significant figures
ordered tests according to types and exponents
|
Please take a look @angularsen , I think it's okay now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it is on demand, conversion values of a property in
UnitDefinition/*.jsonfiles and those inCustomCode/*.csfiles must be expressed differently in order to lead tests to reasonable execution. in case of specific energy, I noticed that there is no such consistency. on both side conversion factors from/to base unit are expressed identically. For instance,in UnitDefinition :
"FromBaseToUnitFunc": "x/4.184e3"in CustomCode :
"CaloriesPerGramInOneJoulePerKilogram": "x/4.184e3",