New Quantity: SpecificVolume #351
Conversation
0xferit
changed the title
|
|
||
| <s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=Full/@EntryIndexedValue"><?xml version="1.0" encoding="utf-16"?><Profile name="Full"><CSUseVar><BehavourStyle>CAN_CHANGE_BOTH</BehavourStyle><LocalVariableStyle>IMPLICIT_WHEN_INITIALIZER_HAS_TYPE</LocalVariableStyle><ForeachVariableStyle>ALWAYS_EXPLICIT</ForeachVariableStyle></CSUseVar><CSUpdateFileHeader>True</CSUpdateFileHeader><CSOptimizeUsings><OptimizeUsings>True</OptimizeUsings><EmbraceInRegion>False</EmbraceInRegion><RegionName></RegionName></CSOptimizeUsings><CSShortenReferences>True</CSShortenReferences><CSReformatCode>True</CSReformatCode><CSharpFormatDocComments>True</CSharpFormatDocComments><CSReorderTypeMembers>True</CSReorderTypeMembers><CSRemoveCodeRedundancies>True</CSRemoveCodeRedundancies><CSArrangeThisQualifier>True</CSArrangeThisQualifier><RemoveCodeRedundancies>True</RemoveCodeRedundancies><CSUseAutoProperty>True</CSUseAutoProperty><CSMakeFieldReadonly>True</CSMakeFieldReadonly><XMLReformatCode>True</XMLReformatCode><CSCodeStyleAttributes ArrangeTypeAccessModifier="True" ArrangeTypeMemberAccessModifier="True" SortModifiers="True" RemoveRedundantParentheses="True" AddMissingParentheses="True" ArrangeBraces="False" ArrangeAttributes="True" ArrangeArgumentsStyle="True" /><CSEnforceVarKeywordUsageSettings>True</CSEnforceVarKeywordUsageSettings><CSMakeAutoPropertyGetOnly>True</CSMakeAutoPropertyGetOnly><CSArrangeQualifiers>True</CSArrangeQualifiers><CSFixBuiltinTypeReferences>True</CSFixBuiltinTypeReferences></Profile></s:String> | ||
| <s:String x:Key="/Default/CodeStyle/CodeCleanup/SilentCleanupProfile/@EntryValue">Full</s:String> | ||
| <s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_ACCESSORHOLDER_ATTRIBUTE_ON_SAME_LINE_EX/@EntryValue">NEVER</s:String> |
There was a problem hiding this comment.
Not sure if you noticed this change, but it's fine as it's just ReSharper migration stuff due to opening solution with a newer version of ReSharper. No need for a separate PR, but it could have been mentioned in the PR description.
There was a problem hiding this comment.
I didn't notice this, would you like me to roll this change back?
There was a problem hiding this comment.
No it's fine, it will be added eventually by someone anyway.
| // Public structures can't have any members other than public fields, and those fields must be value types or strings. | ||
| // Public classes must be sealed (NotInheritable in Visual Basic). If your programming model requires polymorphism, you can create a public interface and implement that interface on the classes that must be polymorphic. | ||
| #if WINDOWS_UWP | ||
| public sealed partial class Density |
There was a problem hiding this comment.
Fixed in the last commit.
| { | ||
|
|
||
| #if !WINDOWS_UWP | ||
| public static Density operator /(Double constant, SpecificVolume volume) |
There was a problem hiding this comment.
It makes absolutely no practical difference, but my OCD gets the shivers when seeing Double vs double :-)
There was a problem hiding this comment.
Can't blame : ) Gonna change it to double
There was a problem hiding this comment.
Fixed in the last commit.
| "PluralName": "CubicMetersPerKilogram", | ||
| "FromUnitToBaseFunc": "x", | ||
| "FromBaseToUnitFunc": "x", | ||
| "Prefixes": [ ], |
There was a problem hiding this comment.
Any other units that is worth adding while at it for this quantity? I assume the operator overloads is what you are primarily using this for.
There was a problem hiding this comment.
CubicMetersPerKilogram is enough for us for now but if there are other units you would like to see, I can happily implement.
|
Cool, thanks! I'll let you do the release, if you wish. |
2 participants
SpecificVolume
Units
CubicMeterPerKilogramConversions