Added SolidAngle and ThermalConductivity. #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidAngle - Steradian (sr) ThermalConductivity - WattPerMeterKelvin (W/m·K)
angularsen
requested changes
Jan 20, 2018
| "SingularName": "Steradian", | ||
| "PluralName": "Steradians", | ||
| "FromUnitToBaseFunc": "x", | ||
| "FromBaseToUnitFunc": "x", |
There was a problem hiding this comment.
Consider adding these units?
http://www.calculator.org/property.aspx?name=solid+angle
There was a problem hiding this comment.
We listed in this PR only the units we're really using. We know that probably their relative physical quantities could be expanded with more definitions and prefixes but they're out of scope at the moment.
We are committed to adding them in future if their usage will become necessary.
There was a problem hiding this comment.
That is fair. They can be added later if someone finds them useful.
| "BaseUnit": "WattPerMeterKelvin", | ||
| "XmlDoc": "Thermal conductivity is the property of a material to conduct heat.", | ||
| "XmlDocRemarks": "https://en.wikipedia.org/wiki/Thermal_Conductivity", | ||
| "Units": [ |
There was a problem hiding this comment.
Any prefix units to add?
Add these units?
http://www.unitconversion.org/unit_converter/thermal-conductivity.html
angularsen
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SolidAngle - Steradian (sr)
ThermalConductivity - WattPerMeterKelvin (W/m·K)