Skip to content

Conversation

gojanpaolo
Copy link
Contributor

@gojanpaolo gojanpaolo commented Jan 14, 2018

Fixes #377

Concerns:
How to handle negative radius/diameter

  1. Should we throw exception?
  2. Should we just ignore (or absolute value)?
    • Current implementation is ignored which implicitly gets absolute value since it squares the value

Need to add tests either case.

Note:
High precision area of circle online calculator

Fixes #377

Concerns:
How to handle negative radius/diameter
@angularsen
Copy link
Owner

Hm, since the default behavior is that of absolute value, I see no reason to handle this specifically so I think we should simply allow it.

@angularsen angularsen merged commit 6d9888c into angularsen:master Jan 14, 2018
@angularsen
Copy link
Owner

Ok maybe I merged a bit early if you intended to add test case for the negative values, can add that separately I guess :-) Sorry!

@gojanpaolo
Copy link
Contributor Author

Ahh lol. That's fine. We can add the test case next time. Implementation will not change anyway. :)
Thank you!

@gojanpaolo gojanpaolo deleted the AddAreaCircleMethods branch January 14, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants