Add 'SlugSquareFoot' and 'SlugSquareInch' as units of MassMomentOfIntertia, and 'slug' as a unit of Mass #482
Conversation
Common/UnitDefinitions/Mass.json
Outdated
| "SingularName": "Slug", | ||
| "PluralName": "Slugs", | ||
| "FromUnitToBaseFunc": "x/6.85217659e-2", | ||
| "FromBaseToUnitFunc": "x*6.85217659e-2", |
There was a problem hiding this comment.
Tiny rounding error, I believe it is 6.852176556196105e-2 according to
https://www.convertunits.com/from/slug/to/kg
https://en.wikipedia.org/wiki/Slug_(unit).
| { | ||
| "SingularName": "SlugSquareFoot", | ||
| "PluralName": "SlugSquareFeet", | ||
| "FromUnitToBaseFunc": "x*1.35583", |
There was a problem hiding this comment.
1.3558179619 according to https://www.unitconverters.net/moment-of-inertia/slug-square-foot-to-kilogram-square-meter.htm
| { | ||
| "SingularName": "SlugSquareInch", | ||
| "PluralName": "SlugSquareInches", | ||
| "FromUnitToBaseFunc": "x*9.41548e-3", |
There was a problem hiding this comment.
|
@McNeight Just a follow up, I'm waiting for your feedback on how to proceed here. |
|
@McNeight I don't mean to nag, but still waiting for you on this one. Only minor changes required to merge this. |
…ertia, and 'slug' as a unit of Mass
|
@angularsen I apologize for the delay, but I've made the changes you've requested. For future reference, what are good sources for conversion constants, and how many significant digits do you prefer? |
|
Awesome! I addet a new bullet point to the list:
Good sources are google and various conversion websites. I usually double check with two sources. In the wiki there is an example on how to look up these factors. |
|
I changed the wording to
|
|
Nuget on the way out |
|
Awesome! I just realized that I forgot to modify the test cases. It looks like the tolerance was loose enough that they passed. If it's easier, I can open a second issue to merge that in. |
|
Yes please, good to have it in I think |
Updated conversion constants in test cases from #482
|
Released in 3.107.1. |
No description provided.