Static properties should be read-only properties with inline initiali… #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static properties should be read-only properties with inline initialization rather than lambdas.
|
Nice catch! I didn't notice before now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static properties should be read-only properties with inline initialization rather than lambdas.
For example, using a lambda for the Zero property would create a new Acceleration(0, BaseUnit) every time it's called, rather than just initializing it once.
A quick test of calling these properties 100,000,000 times showed the lambdas were roughly 10x slower. Not a huge deal but, thought I'd fix it 😃