IQuantity As/ToUnit method exceptions #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IQuantity As/ToUnit methods would allow casting an Enum to the wrong unit type. Throw exception.
tmilnthorp
commented
Mar 1, 2019
angularsen
approved these changes
Mar 1, 2019
| /// <inheritdoc /> | ||
| double IQuantity.As(Enum unit) | ||
| { | ||
| if(!(unit is AmountOfSubstanceUnit)) |
There was a problem hiding this comment.
Optional, but you can rewrite this to latest c# for extra vanity points:
if (unit is AmountOfSubstanceUnit validUnit)
{
return As(validUnit);
}
throw new ArgumentException("The given unit is not of type AmountOfSubstanceUnit.", nameof(unit));There was a problem hiding this comment.
Also, we could add unit.GetType() to the exception message to give extra help figuring out what went wrong.
There was a problem hiding this comment.
I only thought you could do that with as. Sweet! And I agree, I updated the message.
Pretty :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IQuantity As/ToUnit methods would blindly cast an Enum to the unit type, even if it was the wrong unit type. Throwing an exception for wrong type.