Skip to content

Conversation

CPMOliveira
Copy link
Contributor

It is a unit very used in hydrology.

Cristiano Oliveira and others added 2 commits March 6, 2019 14:09
It is a unit very used in hydrology.
@angularsen
Copy link
Owner

Hi, thanks for contributing. You're missing the generated code, just run generate-code.bat, commit and push that to the branch.

Please see https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit for detailed instructions.

@angularsen angularsen changed the title Add Cubic Hectometer Add Volume.CubicHectometer Mar 6, 2019
@tmilnthorp
Copy link
Collaborator

Should new units be added to the end of json files? I know we don't preserve enum ordering (it's alphabetical). But we could and it would allow persistence of enum values.

@angularsen
Copy link
Owner

Fair question, I haven't really paid much attention to it so far. I guess I would favor keeping it alphabetically, but I have no strong opinion on this.

@CPMOliveira
Copy link
Contributor Author

Hi, thanks for contributing. You're missing the generated code, just run generate-code.bat, commit and push that to the branch.

Please see https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit for detailed instructions.

I'm sorry, but I'm new here. Thanks for the correction and inform the instructions.
Great job!

@CPMOliveira CPMOliveira closed this Mar 6, 2019
@angularsen
Copy link
Owner

angularsen commented Mar 6, 2019

@CPMOliveira No problem, also you can keep this pull request. No need to close it, just push new commits to the same branch patch-1.

@CPMOliveira CPMOliveira reopened this Mar 7, 2019
@CPMOliveira CPMOliveira closed this Mar 7, 2019
@CPMOliveira
Copy link
Contributor Author

Moved to #638

@CPMOliveira CPMOliveira deleted the patch-1 branch March 7, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants