Skip to content

Conversation

dschuermans
Copy link
Contributor

@dschuermans dschuermans commented Feb 5, 2020

Fixes #732.

Reworked UnitsNetJsonConverter according to #732.
Also split up serialization and deserialization tests into seperate files for better readability and extracted test objects into their own classes. Consider this an overall clean-up of the test project

…t up serialization and deserialization tests into seperate files for better readability and extracted test objects into their own classes. Consider this an overall clean-up of the test project
@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #746 into master will increase coverage by 0.96%.
The diff coverage is 97.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   61.92%   62.89%   +0.96%     
==========================================
  Files         171      273     +102     
  Lines       38457    39630    +1173     
==========================================
+ Hits        23814    24924    +1110     
- Misses      14643    14706      +63
Impacted Files Coverage Δ
...Net.Serialization.JsonNet/UnitsNetJsonConverter.cs 42.96% <ø> (-43.07%) ⬇️
...Serialization.JsonNet/Internal/ReflectionHelper.cs 44.44% <ø> (-8.89%) ⬇️
...Serialization.JsonNet/UnitsNetBaseJsonConverter.cs 100% <100%> (ø)
...lization.JsonNet/UnitsNetIQuantityJsonConverter.cs 100% <100%> (ø)
...zation.JsonNet/UnitsNetIComparableJsonConverter.cs 90% <90%> (ø)
UnitsNet/GeneratedCode/UnitConverter.g.cs 100% <0%> (ø) ⬆️
...ns/GeneratedCode/NumberToLuminosityExtensions.g.cs 100% <0%> (ø)
...nsions/GeneratedCode/NumberToEnergyExtensions.g.cs 100% <0%> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4d6c5...9e18710. Read the comment docs.

@dschuermans
Copy link
Contributor Author

@angularsen If you want better code coverage, I could always update the unit tests to also test the actual converters.
The current tests are actually integration tests if you look at it 😮

@dschuermans
Copy link
Contributor Author

Okay, i'm adding tests for the converters themselves at the moment 😄

@dschuermans
Copy link
Contributor Author

Okay, i'm done now 👍

@angularsen
Copy link
Owner

angularsen commented Feb 5, 2020 via email

@angularsen
Copy link
Owner

angularsen commented Feb 7, 2020 via email

@dschuermans dschuermans force-pushed the feature/732-UnitsNetJsonConverter branch from 5cc5fc2 to 9e18710 Compare February 7, 2020 09:18
@angularsen angularsen merged commit 3221861 into angularsen:master Feb 9, 2020
@angularsen
Copy link
Owner

Great job, thanks!

@angularsen
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework of UnitsNetJsonConverter
3 participants