Add Energy.WattDays (including SI Prefixes) #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 62.97% 63.02% +0.04%
==========================================
Files 273 273
Lines 39723 39773 +50
==========================================
+ Hits 25017 25067 +50
Misses 14706 14706
Continue to review full report at Codecov.
|
trb5016
changed the title
angularsen
approved these changes
Feb 21, 2020
|
|
||
| protected override double WattHoursInOneJoule => 0.000277777778; | ||
|
|
||
| protected override double WattDaysInOneJoule => 1.157407407407410E-05; |
There was a problem hiding this comment.
I couldn't find a source on this, but WattHours value / 24 give this so looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding WattDays as a unit of energy (and Tera, Giga, Mega, Kilo SI prefixes).
Useful for electric utility scale measurement of energy. Also added to support future additions of other quantities.