Skip to content

Conversation

rennolaj
Copy link
Contributor

@rennolaj rennolaj commented Mar 3, 2020

Dear UnitsNet community,

We are very happy with the work you have done here, my colleagues and I are using this library
for a project, and we needed this specific unit as part of the requirements.

Please try to review the PR as soon as possible
Thank you in advance

Javier Rennola

Javier Rennola and others added 2 commits March 3, 2020 15:33
@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #765 into master will increase coverage by 0.05%.
The diff coverage is 68.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   63.29%   63.34%   +0.05%     
==========================================
  Files         273      275       +2     
  Lines       40063    40534     +471     
==========================================
+ Hits        25357    25678     +321     
- Misses      14706    14856     +150
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100% <ø> (ø) ⬆️
...NumberToElectricPotentialChangeRateExtensions.g.cs 100% <100%> (ø)
UnitsNet/GeneratedCode/UnitConverter.g.cs 100% <100%> (ø) ⬆️
...edCode/Quantities/ElectricPotentialChangeRate.g.cs 63.39% <63.39%> (ø)
UnitsNet/GeneratedCode/Quantity.g.cs 81.46% <80%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac63aa6...6c21b5a. Read the comment docs.

@angularsen
Copy link
Owner

Looks perfect to me, thanks!
I only adjusted the syntax of the test values slightly to a consistent scientific notation.

@angularsen angularsen changed the title Added ElectricPotentialChangeRate Add ElectricPotentialChangeRate Mar 4, 2020
@angularsen angularsen merged commit ac97473 into angularsen:master Mar 4, 2020
@angularsen
Copy link
Owner

Nuget on the way out.
Release UnitsNet/4.51.0 · angularsen/UnitsNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants