Support case insensitive parsing of quantities #781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make it easier to define unit abbreviations in order for
Parse()
to work for all variations of upper/lowercase in the unit abbreviation.This was already supported for
UnitParser
and even thoughQuantityParser
builds on top ofUnitParser
, it failed due to a regex it computes based on the list of unit abbreviations.Design
UnitNotFoundException
inUnitParser
.Examples
Volume.Parse("1 L")
currently fails, because only lowercasel
is defined in JSON. There are no other volume units with the same lowercase abbreviation.Changes
QuantityParser