Skip to content

Add Russian frequency units #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2020

Conversation

Dblm0
Copy link
Contributor

@Dblm0 Dblm0 commented Sep 2, 2020

#766

Some Russian frequency units translations have been added, except for cpm cph and bpm

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #829 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         281      281           
  Lines       41915    41925   +10     
=======================================
+ Hits        33760    33770   +10     
  Misses       8155     8155           
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100.00% <ø> (ø)
UnitsNet/GeneratedCode/UnitConverter.g.cs 100.00% <0.00%> (ø)
...nsions/GeneratedCode/NumberToEnergyExtensions.g.cs 100.00% <0.00%> (ø)
UnitsNet/GeneratedCode/Quantities/Energy.g.cs 88.24% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b26020...2118263. Read the comment docs.

@angularsen
Copy link
Owner

I'll have to trust your translations, but could you also please run generate-code.bat and push the updated source code?

@Dblm0
Copy link
Contributor Author

Dblm0 commented Sep 3, 2020

I'll have to trust your translations, but could you also please run generate-code.bat and push the updated source code?

done

@stale
Copy link

stale bot commented Nov 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 3, 2020
@stale stale bot closed this Nov 10, 2020
@angularsen angularsen reopened this Nov 13, 2020
@stale stale bot removed the wontfix label Nov 13, 2020
@angularsen angularsen merged commit d4f05cb into angularsen:master Nov 13, 2020
@angularsen
Copy link
Owner

Sorry for the slow response on my part, looks good thanks!

@angularsen
Copy link
Owner

angularsen commented Nov 14, 2020

Nuget is on the way out
Release UnitsNet/4.74.0 · angularsen/UnitsNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants