Skip to content

Conversation

josesimoes
Copy link
Contributor

No description provided.

@angularsen angularsen merged commit 5132b71 into angularsen:master May 17, 2021
@angularsen
Copy link
Owner

Release UnitsNet/4.91.0 · angularsen/UnitsNet

@josesimoes josesimoes deleted the update-nf-mscorlib branch June 17, 2021 14:06
@angularsen
Copy link
Owner

@josesimoes @Ellerbach I changed the nanoFramework codegen to not update nuget versions by default, you have to opt in with a new flag. It is documented here.

https://github.com/angularsen/UnitsNet/wiki/nanoFramework

The reason is that pull requests unrelated to nanoFramework often got spammed with updates to nanoFramework versions, which confused the contributors and made the PR harder to review.

@josesimoes
Copy link
Contributor Author

OK. That makes sense.

I just have a question : from now on, how will the updates be handled? I mean when a new release of those Nugets comes out, should a manual build be triggered? Guess there is no need to submit PRs... 🤔

@angularsen
Copy link
Owner

Update via PR as before. When you run the command in the wiki, it will update the project files with the latest mscorlib/system.math versions. I did one update just now, but I skipped doing a pull requests since I didn't need a review on the change.

ff0fa59

@Ellerbach
Copy link
Contributor

Update via PR as before. When you run the command in the wiki, it will update the project files with the latest mscorlib/system.math versions. I did one update just now, but I skipped doing a pull requests since I didn't need a review on the change.

ff0fa59

So in other words, you decoupled the "normal" version with then "nano" version. which makes sense anyway. Most of the time the nano version is updated because of MS CoreLib or Math as they are based on the units only.

So that makes sense for me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants