updated nF core to 1.10.4-preview.11 #928
Conversation
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
| <ProjectTypeGuids>{11A8DD76-328B-46DF-9F39-F559912D0360};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | ||
| <ProjectGuid>{3985716e-fa45-4c63-92a7-d656cc46d421}</ProjectGuid> | ||
| <ProjectGuid>{9f2a32c7-6fcd-4987-ab43-c0b18d616762}</ProjectGuid> |
There was a problem hiding this comment.
I see the code generator could be improved to try to keep the guids if they already exist, instead of re-generating every time. Maybe by taking a hash of the project name or similar.
Just an observation, not blocking this PR.
There was a problem hiding this comment.
I pushed a fix for deterministic project/solution guids. Please re-generate.
|
Think I've got it all in and correct. Apologies if not, still new to UnitsNet and nanoFramework so please bear with me. |
|
Found another issue with the codegen, running codegen locally for me found |
|
No need to apologize! This is great work. Most of the problems you ran into were due to the codegen having some minor bugs and inconsistencies that are now fixed as a result of your PR. nanoFramework is still very new to us. Nuget is hopefully on the way out, within 30 minutes or so. 🎉 |
|
Awesome, thanks SO MUCH! |
No description provided.