Skip to content

Conversation

rschiefer
Copy link
Contributor

Added code to automatically generate the nuspec file for UnitsNet.nanoFramework units. Used placeholder ($version$) for version number in nuspec so will probably need to pass that in the build pipeline (unless thats a builtin variable, not sure). nanoFramework.IoT.Device generates their nuget packages in the same way.

@rschiefer
Copy link
Contributor Author

Just realized I didn't catchup my branch of the main repo before creating my branch. WOrking on that now.

@angularsen
Copy link
Owner

angularsen commented May 25, 2021

Perfect. What's missing before merging this is how to do versioning. GitVersion has been mentioned. I briefly looked it up. Is that something you could help set up if you've done it before?

One thing that might pose a challenge is that nugets are versioned separately in these groups:

  • UnitsNet, UnitsNet.NumberExtensions, UnitsNet.nanoFramework.*, UnitsNet.WindowsRuntimeComponent
  • UnitsNet.Serialization.JsonNet

@rschiefer
Copy link
Contributor Author

Sorry I've never setup GitVersion before. I hardcoded the version number for now to buy us some time.

@angularsen angularsen merged commit b44eed1 into angularsen:master May 27, 2021
@angularsen
Copy link
Owner

@rschiefer Thanks a lot. Nugets 4.92 are now out.

@rschiefer
Copy link
Contributor Author

Thats great, thanks!

@rschiefer
Copy link
Contributor Author

@angularsen I'm not seeing the unitsnet.nanoframework.power nuget package. This was one of the decimal conversions so it wasn't previously available. Anything special we need to do to get it up to nuget?

@angularsen
Copy link
Owner

@rschiefer Yes the published nugets are hand-picked for now.
https://github.com/angularsen/UnitsNet/blob/master/Build/build-pack-nano-nugets.psm1

We didn't want to barf all 100+ packages out unless there was demand for them.

@rschiefer
Copy link
Contributor Author

ok, i'll update with the missing units we need. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants