json: Support custom quantities #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Activator is used to instantiate objects, instead of calling Quantity.From. The assumption is that there will be a constructor of new T(double value, TUnit unit).
|
Thanks, I'll try to get around to this in a couple of days. |
angularsen
requested changes
Jun 12, 2021
Use ConcurrentDictionary Move test to Serialization
angularsen
changed the title
|
@giantmustache UnitsNet.Serialization.JsonNet 4.4.0 nuget is on the way out, it would be great if you could give it a try and report back that it works. Queued build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Activator is used to instantiate objects, instead of calling Quantity.From.
The assumption is that there will be a constructor of new T(double value, TUnit unit).
More info in issue #934