Skip to content

Fix referencing stable/preview NuGets for .NET nanoFramework #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Fix referencing stable/preview NuGets for .NET nanoFramework #958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0851e02
Fix referencing stable/preview NuGets for .NET nanoFramework
josesimoes Aug 9, 2021
5f7cec9
Rework code to remove checks for stable/preview versions
josesimoes Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions CodeGen/Generators/NanoFrameworkGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,30 +140,27 @@ private static void SetDependencyVersions(FindPackageByIdResource resource, Sour
logger,
cancellationToken).Result;

// NuGet package Version
// including preview
var mscorlibPackage = packageVersions.Where(v => v.IsPrerelease).OrderByDescending(v => v).First();
// stable only
//var mscorlibPackage = packageVersions.OrderByDescending(v => v).First();
// get NuGet package Version for mscorlib
// grab latest available (doesn't matter if it's preview or stable)
NuGetVersion mscorlibVersion = packageVersions.OrderByDescending(v => v).First();
MscorlibVersion = mscorlibVersion.Version.ToString();
MscorlibNuGetVersion = mscorlibVersion.ToNormalizedString();

MscorlibVersion = mscorlibPackage.Version.ToString();
MscorlibNuGetVersion = mscorlibPackage.ToNormalizedString();

// Math
// System.Math
packageVersions = resource.GetAllVersionsAsync(
"nanoFramework.System.Math",
cache,
logger,
cancellationToken).Result;

// NuGet package Version
// including preview
var mathPackage = packageVersions.Where(v => v.IsPrerelease).OrderByDescending(v => v).First();
// stable only
//var mathPackage = MathNuGetVersion = packageVersions.OrderByDescending(v => v).First();
// grab latest available (doesn't matter if it's preview or stable)
// making an assumption here that the available version is referencing the correct mscolib
var mathVersion = packageVersions.OrderByDescending(v => v).First();
MathVersion = mathVersion.Version.ToString();
MathNuGetVersion = mathVersion.ToNormalizedString();

MathVersion = mathPackage.Version.ToString();
MathNuGetVersion = mathPackage.ToNormalizedString();
logger.LogInformation($"Referencing nanoFramework.CoreLibrary {MscorlibNuGetVersion}");
logger.LogInformation($"Referencing nanoFramework.System.Math {MathNuGetVersion}");
}
else
{
Expand Down