You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Release notes
Changes
Fixed that a failed login to a custom OCI-registry aborted the whole build instead of falling back to the upstream-registry. OCIImageManager.__custom_registry_provides_image now performs the ScriptCollectionCore.login_to_defined_docker_registries-call as a best-effort step: if the login fails - because the custom registry is not reachable, because the credentials are missing or wrong, or because the docker-daemon is not available at all - a warning is logged and the image is treated as not available in the custom registry. This lets the already existing fallback in OCIImageManager.get_registry_address_for_image use the upstream-registry which the repository defines in <repository>/.ScriptCollection/OCIImages/ImageDefinition.csv, which is the behavior intended for all of these cases. Before this change the login-exception propagated and let scbuildcodeunits (and therefore task bb) fail, although the fallback-registry could have delivered the image. The login-failure is only reported once because the login is memoized for the runtime of the process, so a later docker_pull does not retry it.