Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept all guzzle options in tus client #90

Merged
merged 2 commits into from
Oct 21, 2018
Merged

Accept all guzzle options in tus client #90

merged 2 commits into from
Oct 21, 2018

Conversation

ankitpokhrel
Copy link
Owner

See #75, #88

@ankitpokhrel ankitpokhrel self-assigned this Oct 21, 2018
@samundra samundra self-requested a review October 21, 2018 10:51
samundra
samundra approved these changes Oct 21, 2018
View reviewed changes
Copy link
Collaborator

@samundra samundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to Me. However, rather than throwing Generic Exception, it can be wrapped into TusException so that it can be handled appropriately by the users.

@ankitpokhrel ankitpokhrel mentioned this pull request Oct 21, 2018
Closed
@ankitpokhrel ankitpokhrel merged commit 6d6e987 into master Oct 21, 2018
@ankitpokhrel ankitpokhrel deleted the issue-88 branch October 21, 2018 17:44
@ankitpokhrel ankitpokhrel mentioned this pull request Oct 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samundra samundra samundra approved these changes

Assignees

@ankitpokhrel ankitpokhrel

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitpokhrel @samundra