Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Pull Request Template #75

Closed
gauthamzz opened this issue Dec 20, 2017 · 11 comments
Closed

create Pull Request Template #75

gauthamzz opened this issue Dec 20, 2017 · 11 comments

Comments

@gauthamzz
Copy link
Member

Should check for:-

  1. Issue is linked in the commit
  2. Proper commit messages are written
  3. Refer template of any open source project you like and follow similar
@lalitmee
Copy link
Contributor

@gauthamzz what do you think about this template?

@gauthamzz
Copy link
Member Author

That's contribution guides we already have that . Just link that it's enough.

@lalitmee
Copy link
Contributor

Should I create a link for this template in the readme.md file.

@gauthamzz
Copy link
Member Author

No.

See this https://github.com/fossiiita/opencode2017/blob/master/PULL_REQUEST_TEMPLATE.md don't add the last part. And tell them to read the docs once.

@lalitmee
Copy link
Contributor

You mean I can add this one. From code practices to tutorials. Am I right?

@gauthamzz
Copy link
Member Author

The link I send is what we want. It's pull request template it shouldn't be huge. And remove that part of link . Instead make like add relevant images in the comment

gauthamzz pushed a commit that referenced this issue Dec 30, 2017
* added issues open badge

* added issues open badge

* added issues open badge

* Added zulip chat and Coday badge

* Modified issues open badge for showing current opened issues

* Added Download from Chrome-Webstore badge

* modified chrome webstore badge

* Update README.md

* updating

* updating

* updating

* Adding PullRequestTemplate.md

* Adding PullRequestTemplate.md

* Created a pull request template

* Created a pull request template

* Modifying pull request template

* Added Contributing.md and PullRequestTemplate.md files
@lalitmee
Copy link
Contributor

@gauthamzz Can we set up a slack channel for Anna. I know that we have zulip-chat. But I think slack would be more attractive and user-friendly. I just want your opinion.

@gauthamzz
Copy link
Member Author

we promote opensource thats why we use zulip.
zulip is good if you try it. its very fast . I think we will stay with zulip for now.

@gauthamzz
Copy link
Member Author

closed at #105 by @lalitmee

@lalitmee
Copy link
Contributor

Ok. I was saying because I haven't used Zulip. But no problem. I am adaptable to change. hahaha.

@gauthamzz
Copy link
Member Author

I have used slack and discord as well. I think of them two discord is better. But for zulip is the best for our purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants