Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tower abci shed Info requests when overloaded, no shed mempool #2152

Merged
merged 34 commits into from
Nov 11, 2023
Merged

tower abci shed Info requests when overloaded, no shed mempool #2152

merged 34 commits into from
Nov 11, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Nov 11, 2023 •
edited
Loading

Describe your changes

  • Removed the buffer and load-shedding from Mempool requests - they cannot be shed as it makes CometBFT crash and without it the client will simply timeout when the node doesn't respond in time
  • Switched to tower-abci fork with load-shed error handling for Info requests. This is needed to avoid tower-abci crashing when it's spammed with queries

Indicate on which release or other PRs this topic is based on

#2141

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

yito88 and others added 30 commits October 26, 2023 21:18
@yito88
refactor ibc context
e7b6c6f
@yito88
refactor IbcStorageContext
3d95646
@yito88
fix write
9e21092
@yito88
error messages
edec801
@yito88
remove unused borsh
4c6e92b
@yito88
add changelog
5ee4ed4
@yito88
fix error handling and counter value
ec0391f
@yito88
for CI
1dcac81
@yito88
Merge branch 'base' into yuji/refactor-ibc
23c5d4f
@yito88
WIP: restruct IBC contexts
60eba3d
@yito88
WIP: add TokenTransferContext
6a2a049
@yito88
WIP: fix ibc tests
6d35456
@yito88
WIP: fix for tendermint
ed1c974
@yito88
fix for tests
c950ea9
@yito88
fix for IBC Mock
b1a2478
@yito88
fix for fast_sync
2ce3798
@yito88
workaround for ChainId
5df0ec1
@yito88
ibc-rs 0.47.0
9f05784
@yito88
fix workaround for AppState
4dbc2d8
@yito88
fix check-crates
f5b23fe
@yito88
fix bench
7116b6a
@tzemanovic
remove "abcipp" feature
9f4ebc7
@tzemanovic
rm dkg with ferveo
17d8e48
@tzemanovic
refresh localnet pre-genesis validator
3247ee7
@tzemanovic
test: load validator keys from pre-genesis wallet
a3033ac
@tzemanovic
regen integration masp proofs
1f77911
@tzemanovic
deps: switch to last release of tower-abci
cac3e53
@tzemanovic
set mempool buffer size to default Comet's mempool size
d361d9d
@tzemanovic
refactor to use TM domain types
6fbefdc
@tzemanovic
test/storage: fix block height read test
13ea167
@tzemanovic tzemanovic marked this pull request as ready for review November 11, 2023 14:08
@tzemanovic tzemanovic mentioned this pull request Nov 11, 2023
Closed
tzemanovic added a commit that referenced this pull request Nov 11, 2023
@tzemanovic
Merge branch 'tomas/tower-abci-shed' (#2152)
0095af7 
* tomas/tower-abci-shed:
  changelog: add #2152
  deps: switch to tower-abci fork with info requests load-shedding
  ledger: don't buffer or load shed mempool requests
tzemanovic added a commit that referenced this pull request Nov 11, 2023
@tzemanovic
Merge branch 'tomas/tower-abci-shed' (#2152)
cd13de6 
* tomas/tower-abci-shed:
  changelog: add #2152
  deps: switch to tower-abci fork with info requests load-shedding
  ledger: don't buffer or load shed mempool requests
@adrianbrink adrianbrink merged commit a4cf45e into main Nov 11, 2023
12 of 14 checks passed
@adrianbrink adrianbrink deleted the tomas/tower-abci-shed branch November 11, 2023 20:05
@cwgoes cwgoes mentioned this pull request Nov 11, 2023
Closed
This was referenced Apr 18, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzemanovic @adrianbrink @yito88