Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: switch back to upstream tower-abci v0.11.1 #3137

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Apr 25, 2024

Describe your changes

I can no longer reproduce the issue that we fixed in #2152 with the query error handling. When the service is overloaded, CometBFT simply reports e.g. failed to write responses module=rpc-server err="write tcp 127.0.0.1:27657->127.0.0.1:36888: i/o timeout and both Namada and Comet continue to run without any issues.

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (97ec5b4) to head (5ca8ecb).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3137   +/-   ##
=======================================
  Coverage   59.39%   59.39%           
=======================================
  Files         298      298           
  Lines       92771    92771           
=======================================
  Hits        55104    55104           
  Misses      37667    37667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic marked this pull request as ready for review April 25, 2024 14:02
brentstone added a commit that referenced this pull request Apr 25, 2024
* tomas/tower-abci-upstream:
  changelog: add #3137
  deps: switch back to upstream tower-abci v0.11.1
@brentstone brentstone mentioned this pull request Apr 25, 2024
@brentstone brentstone merged commit 25e623d into main Apr 27, 2024
19 checks passed
@brentstone brentstone deleted the tomas/tower-abci-upstream branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants