-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DI - IBC #3509
DI - IBC #3509
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3509 +/- ##
==========================================
+ Coverage 54.51% 54.54% +0.02%
==========================================
Files 323 323
Lines 113288 113855 +567
==========================================
+ Hits 61762 62099 +337
- Misses 51526 51756 +230 ☔ View full report in Codecov by Sentry. |
a091488
to
72fc3b8
Compare
BorshDeserializer, | ||
Hash, | ||
)] | ||
pub struct PGFIbcTarget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this here from gov (crates/governance/src/storage/proposal.rs
) as it's being used from ibc actions - it's mostly just for passing could fields with borsh encoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
BorshDeserializer, | ||
Hash, | ||
)] | ||
pub struct PGFIbcTarget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
Describe your changes
Dependency injection for IBC, replacing deps on:
deps graphs
normal only
with dev deps
Indicate on which release or other PRs this topic is based on
Depends-On: #3497
Checklist before merging to
draft