Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI - IBC #3509

Merged
merged 22 commits into from
Aug 2, 2024
Merged

DI - IBC #3509

merged 22 commits into from
Aug 2, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jul 12, 2024

Describe your changes

Dependency injection for IBC, replacing deps on:

  • parameters
  • governance
  • token

deps graphs

  • normal only
    deps

  • with dev deps
    deps-with-tests

Indicate on which release or other PRs this topic is based on

Depends-On: #3497

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 68.87922% with 572 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (1154023) to head (f67da93).
Report is 29 commits behind head on main.

Files Patch % Lines
crates/tx_prelude/src/proof_of_stake.rs 0.00% 59 Missing ⚠️
crates/core/src/ibc.rs 0.00% 56 Missing ⚠️
crates/proof_of_stake/src/queries.rs 41.66% 49 Missing ⚠️
...s/node/src/shell/vote_extensions/val_set_update.rs 0.00% 32 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 30 Missing ⚠️
crates/trans_token/src/lib.rs 61.53% 30 Missing ⚠️
...rates/node/src/shell/vote_extensions/eth_events.rs 0.00% 26 Missing ⚠️
crates/proof_of_stake/src/lib.rs 91.58% 26 Missing ⚠️
crates/shielded_token/src/vp.rs 0.00% 26 Missing ⚠️
crates/sdk/src/queries/vp/pos.rs 0.00% 23 Missing ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3509      +/-   ##
==========================================
+ Coverage   54.51%   54.54%   +0.02%     
==========================================
  Files         323      323              
  Lines      113288   113855     +567     
==========================================
+ Hits        61762    62099     +337     
- Misses      51526    51756     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic force-pushed the tomas/di-ibc branch 2 times, most recently from a091488 to 72fc3b8 Compare July 26, 2024 16:54
@tzemanovic tzemanovic marked this pull request as ready for review July 26, 2024 17:01
@tzemanovic tzemanovic mentioned this pull request Jul 29, 2024
tzemanovic added a commit that referenced this pull request Jul 29, 2024
@tzemanovic tzemanovic marked this pull request as draft July 29, 2024 11:52
tzemanovic added a commit that referenced this pull request Jul 29, 2024
BorshDeserializer,
Hash,
)]
pub struct PGFIbcTarget {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this here from gov (crates/governance/src/storage/proposal.rs) as it's being used from ibc actions - it's mostly just for passing could fields with borsh encoding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@tzemanovic tzemanovic marked this pull request as ready for review July 29, 2024 13:52
BorshDeserializer,
Hash,
)]
pub struct PGFIbcTarget {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Copy link
Contributor

mergify bot commented Jul 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

@tzemanovic tzemanovic mentioned this pull request Aug 1, 2024
2 tasks
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 1, 2024
@mergify mergify bot merged commit f67da93 into main Aug 2, 2024
19 checks passed
@mergify mergify bot deleted the tomas/di-ibc branch August 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants