Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS20 transfer #625

Merged
merged 8 commits into from
Nov 14, 2022
Merged

ICS20 transfer #625

merged 8 commits into from
Nov 14, 2022

Conversation

@yito88 yito88 marked this pull request as ready for review October 18, 2022 11:40
batconjurer
batconjurer previously approved these changes Oct 19, 2022
@yito88 yito88 changed the base branch from yuji/ibc_ack_ftt_coding to main October 20, 2022 14:49
@yito88 yito88 dismissed batconjurer’s stale review October 20, 2022 14:49

The base branch was changed.

tzemanovic
tzemanovic previously approved these changes Oct 20, 2022
tzemanovic
tzemanovic previously approved these changes Oct 21, 2022
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tzemanovic
Copy link
Member

pls update wasm

@tzemanovic
Copy link
Member

the failing e2e tests are from tendermint change in 0.8.1, will merge this to ibc-integration

tzemanovic added a commit that referenced this pull request Oct 21, 2022
* yuji/ibc-ics20-transfer:
  [ci] wasm checksums update
  remove clone
  fix VP reads
  add denom.rs
  fix relay transfer
@tzemanovic tzemanovic mentioned this pull request Oct 21, 2022
5 tasks
juped added a commit that referenced this pull request Nov 14, 2022
* ibc-integration:
  add set_validators
  [ci] wasm checksums update
  use ibc-transfer cmd
  rename local variables
  fix for v0.8.1
  fix a way to call ibc_proof_specs
  fix for ibc integration branch
  add a test for non-IBC transfer on the same chain
  fix for denom decoding
  get receipt absence proof for TimeoutOnClose
  add a failure test
  add timeout and close tests
  add transfer back
  check balances
  add sub_prefix
  with height
  query with the height
  wait the next block
  add update_client
  fix requests
  add sleep
  add transfer test
  changelog: add #626
  changelog: add #625
  changelog: add #298
  changelog: add #261
  [ci] wasm checksums update
  remove clone
  fix header hash
  fix sub-prefix
  replace now func
  fix timeout timestamp
  fix timeout height
  [ci] wasm checksums update
  fix timeout
  add ibc-transfer command
  fix VP reads
  add denom.rs
  fix relay transfer
  fix IBC token VP for ack error
  fix coding for ack and ftt
@juped juped merged commit fc91d99 into main Nov 14, 2022
@juped juped deleted the yuji/ibc-ics20-transfer branch November 14, 2022 18:37
james-chf added a commit that referenced this pull request Nov 24, 2022
* release/v0.10.1: (166 commits)
  Namada 0.10.1
  [ci] wasm checksums update
  ci: added missing make file recipe
  Make clippy happy; buidl WASM locally
  Avoid any reads when delta is 0
  fix masp e2e tests
  fix query balance argument for sub-prefix
  fix for key_may_exist
  test/e2e: re-enable IBC test
  shared/storage: fix get_non_existence_proof block height check
  shared/storage: fix unused imports
  ci: minor fix
  ci: parallel e2e, update mold, add timing artifact, add coverage artifact
  Namada 0.10.0
  tests: ignore ibc e2e test
  wasm: update checksums.json
  query_allowed_conversions: add explicit lifetime for clippy
  Use NAM as default token for shielded txs
  cleanup from review and clippy
  todos from review
  wasm: update checksums
  Shortening epoch durations.
  Updated client queries to reflect new endpoints.
  Fixed error message for overspending. Added missing RPC endpoints: results + conversions. Lengthened E2E test epoch.
  wasm_for_tests: make
  rm dbg prints
  re-use same env var for MASP parameters in the node as in client
  [ci] wasm checksums update
  fix: wasm lib
  fixup: masp e2e tests
  fixup: eth bridge e2e test
  [ci] wasm checksums update
  fix: missing vp_masp in cargo
  Update checksums
  XAN -> NAM
  [ci] wasm checksums update
  simple wasm-runtime ifdef of multithreaded functions
  fix: wasm dependencies
  Add back query_transfers command
  fixup: use wallet address in process_tx call
  add set_validators
  [ci] wasm checksums update
  use ibc-transfer cmd
  rename local variables
  fix for v0.8.1
  fix a way to call ibc_proof_specs
  fix for ibc integration branch
  add a test for non-IBC transfer on the same chain
  fix for denom decoding
  get receipt absence proof for TimeoutOnClose
  add a failure test
  add timeout and close tests
  add transfer back
  check balances
  add sub_prefix
  with height
  query with the height
  wait the next block
  add update_client
  fix requests
  add sleep
  add transfer test
  changelog: add #626
  changelog: add #625
  changelog: add #298
  changelog: add #261
  Update documentation/docs/src/quick-start.md
  create no empty dir before renaming
  Add changelog
  fix: require_latest_height check should skip for requests with height 0
  updated masp docs to actually be docs
  rocksdb: refactor to use pattern match
  doc/dev/pos: add little more details about PoS balance and txs
  specs/pos/reward-distribution: update link to validator sets
  ci: use commit hash instead of pr number
  ci: fix binaries sha
  changelog: add #720
  fix: rename correctly in debug wasm build
  [ci] wasm checksums update [1]
  Add Murisi's MASP verification fix
  Default fee token back to XAN
  [ci] wasm checksums update
  fixup! Merge tag 'v0.8.1' into cwgoes/masp-testnet-revisions
  ordering change
  no longer upgrade
  Update documentation/docs/src/user-guide/ledger/governance.md
  Update documentation/docs/src/user-guide/ledger/governance.md
  Update documentation/docs/src/quick-start.md
  minor change
  some minor changes, fixed breaking change
  documentation changes
  [ci] wasm checksums update
  remove clone
  fix header hash
  Update WASM checksums
  Fix --no-conversions flag
  fix sub-prefix
  Wrote code to print out all conversions.
  replace now func
  fix timeout timestamp
  ...

# Conflicts:
#	.changelog/v0.10.0/bug-fixes/765-ethbridge-ci-fix.md
#	.github/workflows/build-and-test-bridge.yml
#	Cargo.lock
#	apps/src/lib/client/rpc.rs
#	apps/src/lib/client/tx.rs
#	apps/src/lib/node/ledger/mod.rs
#	apps/src/lib/node/ledger/shell/finalize_block.rs
#	apps/src/lib/node/ledger/shell/mod.rs
#	apps/src/lib/node/ledger/shell/process_proposal.rs
#	apps/src/lib/wallet/mod.rs
#	apps/src/lib/wallet/pre_genesis.rs
#	shared/src/ledger/ibc/vp/packet.rs
#	shared/src/ledger/protocol/mod.rs
#	shared/src/ledger/queries/shell.rs
#	shared/src/ledger/storage/mod.rs
#	shared/src/types/address.rs
#	tests/src/e2e/ledger_tests.rs
#	tests/src/e2e/setup.rs
#	wasm/Cargo.lock
#	wasm/checksums.json
#	wasm_for_tests/wasm_source/Cargo.lock
#	wasm_for_tests/wasm_source/Cargo.toml
phy-chain pushed a commit to phy-chain/namada that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBC token transfer doesn't satisfy with ICS20
4 participants