IBC E2E test #664
Merged
IBC E2E test #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
reviewed
Oct 21, 2022
apps/src/lib/client/rpc.rs
Outdated
Comment on lines
1300
to
1307
| match value { | ||
| Some(v) => match T::try_from_slice(&v[..]) { | ||
| Ok(value) => return Some(value), | ||
| Err(err) => eprintln!("Error decoding the value: {}", err), | ||
| }, | ||
| None => return None, | ||
| } | ||
| cli::safe_exit(1) |
There was a problem hiding this comment.
Suggested change
| match value { | |
| Some(v) => match T::try_from_slice(&v[..]) { | |
| Ok(value) => return Some(value), | |
| Err(err) => eprintln!("Error decoding the value: {}", err), | |
| }, | |
| None => return None, | |
| } | |
| cli::safe_exit(1) | |
| if let Some(Err(err)) = value { | |
| eprintln!("Error decoding the value: {}", err); | |
| cli::safe_exit(1) | |
| } | |
| value.map(|inner| inner.unwrap()) |
There was a problem hiding this comment.
I renamed these variables. value is used twice.
batconjurer
previously approved these changes
Oct 21, 2022
yito88
force-pushed
the
yuji/ibc-e2e-test
branch
from
8186170
to
74a52a7
Compare
tzemanovic
reviewed
Oct 21, 2022
|
I've rebased this for v0.8.1 to use |
yito88
force-pushed
the
yuji/ibc-e2e-test
branch
from
ea2852e
to
55ec24c
Compare
tzemanovic
previously approved these changes
Oct 26, 2022
|
pls update wasm |
* yuji/ibc_ack_ftt_coding: [ci] wasm checksums update fix IBC token VP for ack error fix coding for ack and ftt
* yuji/fix_header_hash: fix header hash
* yuji/ibc-ics20-transfer: [ci] wasm checksums update remove clone fix VP reads add denom.rs fix relay transfer
* yuji/ibc-transfer-cmd: fix sub-prefix replace now func fix timeout timestamp fix timeout height fix timeout add ibc-transfer command
juped
force-pushed
the
yuji/ibc-e2e-test
branch
from
764da3e
to
8143264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated #296
depends on #625 and #626
NOTE: need #298 and v0.8.1 for tendermint
block_results()