Move botocore version validation into module_utils.botocore for future reuse #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
ansibullbot
added
community_review
feature
tremble
force-pushed
the
refacter/boto_version
branch
from
bf997c8
to
99a6828
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto_version
branch
from
99a6828
to
3b02cf9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto_version
branch
from
3b02cf9
to
18d4e33
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/boto_version
branch
from
18d4e33
to
251ce0c
Compare
alinabuzachis
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1246
SUMMARY
In preparation for #1225 move the SDK version validation pieces over into module_utils.botocore
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/core.py
plugins/module_utils/exceptions.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION