Refacter docs fragments and synchronize modules and plugins #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
force-pushed
the
refacter/docs_fragments
branch
from
c241c38
to
d837e2a
Compare
ansibullbot
added
community_review
docs
module_utils
tremble
force-pushed
the
refacter/docs_fragments
branch
from
d837e2a
to
482d22e
Compare
tremble
changed the title
tremble
force-pushed
the
refacter/docs_fragments
branch
2 times, most recently
from
3410799
to
2e5ab47
Compare
|
@alinabuzachis While I can't make the botocore/boto3 requirements come directly from requirements.txt, I have found a way to make the docs and code automatically stay in sync. |
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/docs_fragments
branch
from
2e5ab47
to
4e5fc1c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/docs_fragments
branch
2 times, most recently
from
562b9b5
to
6ef29d4
Compare
tremble
force-pushed
the
refacter/docs_fragments
branch
from
d89a990
to
af4011e
Compare
tremble
force-pushed
the
refacter/docs_fragments
branch
from
af4011e
to
ab9c507
Compare
alinabuzachis
approved these changes
Nov 7, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Refacter lookup plugins Depends-On: #1248 SUMMARY Refacters the lookup plugins to use common code for common boto3/botocore operations ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/botocore.py plugins/module_utils/core.py plugins/module_utils/exceptions.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Bulk update to renamed docs fragments SUMMARY Follow up to #1248, we renamed various docs fragments, clean-up amazon.aws ISSUE TYPE Docs Pull Request COMPONENT NAME various ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move some of our docs fragments about to better reflect what they're for and the fact that we now have our own "amazon.aws..." namespace we can use.
Note: the
amazon.aws.common.pluginsfragment will necessitate some changes to the inventory and lookup plugins before use. (See also #1225). However, those changes will then bring them in line with the other modulesISSUE TYPE
COMPONENT NAME
plugins/docs_fragments
ADDITIONAL INFORMATION