ec2_instance - Support throughtput parameter for GP3 volume types #433
Conversation
ansibullbot
added
community_review
feature
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
ec2_instance/throughtput_param
branch
from
69b18e9
to
1c6f5ca
Compare
|
recheck |
1 similar comment
|
recheck |
| if not volume['ebs'].get('iops'): | ||
| volume['ebs']['iops'] = 3000 | ||
| if 'throughput' in volume['ebs']: | ||
| volume['ebs']['throughput'] = int(volume['ebs']['throughput']) |
There was a problem hiding this comment.
maybe set throughput also to its default value 125 if not set?
what happens when the instance exist already? will it keeps the instance values (in case they were changed manually) or will it overwrite them (reset them)? I've no idea.
There was a problem hiding this comment.
Hi @markuman, Thank you for reviewing. I set the default value for throughput.
If my understanding is correct, you can specify different parameters for ebs like throughput and iops only when a new instance is created. In the case an EC2 instance is already present and you would like to modify throughput or iops or both you won’t be allowed because the API allows to modify only a specific subset of BlockDeviceMappings as shows here https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.modify_instance_attribute
I tried by myself to only change these params (throughput for example) and the task resulted in unchanged reflecting the documentation. Therefore, if you want to change throughput or iops values you would need to use the ec2_vol module.
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
aws_kms - stabilize integration tests SUMMARY Integration tests for this test suite were failing occasionally due to timing issues when waiting for < 45 seconds after updates. Increased the wait times to 45 seconds and split into different tests to run in parallel. Fixes ansible-collections#433 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_kms Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de>
SUMMARY
ec2_instance - Support
throughputparameter for GP3 volume typesFixes #395
ISSUE TYPE
COMPONENT NAME
ec2_instance