Skip to content

Conversation

gotmax23
Copy link
Collaborator

Previously, this only would create a PR when the branch was newly created earlier in the workflow (assuming that branches would be deleted once the previous dependency update PR was merged), but it was possible for the branch to already exist but not have a PR open against it. This uses the Github API to properly check whether a PR already exists.

@gotmax23 gotmax23 added no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. labels Mar 26, 2025
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gotmax23 Looks great to me.

Previously, this only would create a PR when the branch was newly
created earlier in the workflow (assuming that branches would be deleted
once the previous dependency update PR was merged), but it was possible
for the branch to already exist but not have a PR open against it.
This uses the Github API to properly check whether a PR already exists.
@gotmax23
Copy link
Collaborator Author

Force pushed to move a misplaced comment. No other changes.

@gotmax23 gotmax23 merged commit 4c56e9f into devel Mar 27, 2025
22 checks passed
@gotmax23 gotmax23 deleted the pip-compile-ci-pr-fix branch March 27, 2025 03:37
@gotmax23
Copy link
Collaborator Author

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants