[stable-2.18] ci: refresh dev dependencies #3069
Conversation
![ansible-documentation-bot[bot]](https://avatars.githubusercontent.com/in/406246?s=60&v=4){kind=small}
ansible-documentation-bot
bot
added
no_backport
tests/formatters.txt
Outdated
| # by the following command: | ||
| # | ||
| # pip-compile --allow-unsafe --output-file=tests/formatters.txt --strip-extras tests/formatters.in | ||
| # pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=tests/formatters.txt --pip-args=None --strip-extras tests/formatters.in |
There was a problem hiding this comment.
@webknjaz Hi, could you take a look at this please? I'm somewhat stumped why pip-compile seems to be explicitly disabling some configuration.
There was a problem hiding this comment.
My guess is that a new release of pip-compile now puts all arguments into this command line, even the None ones. Whether this is a bug or a feature I don't know.
(The latest release of pip-tools is from July 2025, so I'm a bit curious why this didn't happen between then and now already...)
There was a problem hiding this comment.
Thanks @felixfontein I was guessing the same but also saw that about the pip-tools release. And I didn't really see anything that would make pip-compile act differently.
There was a problem hiding this comment.
I think this is actually being generated by uv pip compile now, so you'd want to look at the uv changelog, but it any case, the changes to this header indeed seem inconsequential.
There was a problem hiding this comment.
stable-2.18's noxfile still runs pip-compile. It installs it with session.install("pip-tools >= 7", "pip < 24.3"), so there's no version locking as for newer branches.
There was a problem hiding this comment.
Hmm. I guess the constraints file that we're using applies to the docs-build packages so it seems like a hack to pin click there. Adding a new constraints file for the formatters and other checks seems like overkill.
I guess we can just merge these dep refreshes and ignore the broken check. It affects only stable-2.18 and stable-2.17 so we can keep an eye on it.
The next scheduled dep refresh probably won't fail this check again. We'd probably notice the pip-tools fix added when the check next fails. Hopefully that will remove the explicitly set config.
What do you think?
There was a problem hiding this comment.
Yes, given the responses here, I think that approach makes sense.
I created jazzband/pip-tools#2238.
There was a problem hiding this comment.
Adding a new constraints file for the formatters and other checks seems like overkill.
I would disagree. You're commenting on a problem cause by insufficient pinning that would've been better reproducible/stable if the tool wad pinned.
There was a problem hiding this comment.
I think I meant just for this specific case, as we're on the stable-2.18 branch. Although I take your point.
If we add a new constraints file it should first go on the devel branch. It seems wrong to me to introduce a constraints file in stable-2.18. However there is nothing to pin on devel. Should we just have an empty constrains file until we get to stable-2.18?
There was a problem hiding this comment.
How about just changing https://github.com/ansible/ansible-documentation/blob/stable-2.18/noxfile.py#L161 to
session.install("pip-tools >= 7", "pip < 24.3", "click < 8.3.0")for now?
For devel, stable-2.20, and stable-2.19, we already have tests/pip-compile.in and tests/pip-compile.txt, so there's nothing to do there. (They also use uv.)
|
I think you need to re-run the workflow so it pushes a new version of the lock files to this brnach. |
Thanks, I did try that. |
|
I mean the workflow which pushes to this branch and creates the PR (https://github.com/ansible/ansible-documentation/actions/workflows/pip-compile-dev.yml), not the workflows that run when something has been pushed to this PR (these have been re-run by closing and re-opening). |
ansible-documentation-bot
bot
force-pushed
the
pip-compile/stable-2.18/dev
branch
from
38ba035 to
3222758
Compare
|
I kicked it off here: https://github.com/ansible/ansible-documentation/actions/runs/18140493755 |
|
Ah, thank you @felixfontein 🎉 |
No description provided.