Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect stdout callback being set #400

Closed

Conversation

willthames
Copy link

If stdout callback is set, either through config or environment
variable, it should be respected, not overridden.

@willthames
Copy link
Author

This seems to work if the environment variable is set (as expected) but not if stdout_callback is set in ansible.cfg

It's not clear to me if there's a mechanism to respect ansible.cfg for this variable, but it's an acceptable failure for me.

If ANSIBLE_STDOUT_CALLBACK is set, it should be respected,
not overridden.
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Dec 17, 2019

Build succeeded.

@matburt
Copy link
Member

matburt commented Dec 19, 2019

This does have the effect of short circuiting some of the capability of Runner for gathering this information as part of its event payloads. I wonder if we should wrap this up into a larger effort to clarify support for ansible.cfg.

@willthames
Copy link
Author

It's not just not supporting ansible.cfg though - there has to be some way to override the stdout callback - you can't possibly predict that people will want only either one of the two built in stdout callbacks

@wenottingham
Copy link
Contributor

see #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants