Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy bad path warn #39432

Closed
wants to merge 498 commits into from
Closed

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 27, 2018

SUMMARY

backport #39082

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

ANSIBLE VERSION
2.5

nitzmahone and others added 30 commits March 9, 2018 14:39
The logic was keeping ansible_facts['ansible_lo'] instead of fixing it
to be ansible_facts['lo']

(cherry picked from commit 31878ee)
Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9031533)
* issue:36955 remove creating temp file for debug

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9031533)

* Add changelog fragment for the onyx tempfile issue
*  Connection error messages are unsafe: wrap them (ansible#37329)

* Check that connection error msg are not unsafe

* Connection error messages are unsafe: wrap them

For example, in case of error, docker connection plugin returns exception
message containing Go template. These messages weren't tagged as unsafe
and were consequently rendered:

The conditional check 'result is failed' failed. The error was:
{
  'msg': u'Docker version check ([\'/usr/bin/docker\', \'version\', \'--format\', "\'{{.Server.Version}}\'"]) failed: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.35/version: dial unix /var/run/docker.sock: connect: permission denied\n',
  'failed': True
}:
template error while templating string: unexpected '.'.
String: Docker version check (['/usr/bin/docker', 'version', '--format', "'{{.Server.Version}}'"]) failed: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.35/version: dial unix /var/run/docker.sock: connect: permission denied

(cherry picked from commit 4378542)

* Add a changelog for the no-template error message fix
…7491)

The force parameter is inherently insecure.  Be clearer in the
documentation that this is the case.

Fixes ansible#25242

(cherry picked from commit 5bdc8fe)
* Backport of ACI document changes

* Add missing test change
A fix to a minor typo. ("Previouslu" -> "Previously")

 label: docsite_pr
(cherry picked from commit 0cf2ecb)
* fix more spelling mistakes

* fix spelling mistakes

(cherry picked from commit 16c564c)
This PR includes:
- A fix for multiple-choice defaults
- A fix for messed up dictionary samples
- Cleaner defaults when they don't appear part of choices
(cherry picked from commit 80ba7b7)
(cherry picked from commit 1fd9a61)
(cherry picked from commit 8232c95)
(cherry picked from commit f1899f7)
* revises network portion of 2.5 porting guide
(cherry picked from commit b72960f)
* Fix py3 issue in wait_for_connection (ansible#37646)

(cherry picked from commit 6c3e565)

* Add changelog entry for ansible#36470
bcoca and others added 25 commits April 23, 2018 18:01
…nsible#38302)

* fix set_fact/include_vars looping

* tests for all behaviours affected

* add tests with injection off/on

(cherry picked from commit 2afb109)
…ble#39207)

* Fix for win_get_url module (ansible#39152)


(cherry picked from commit 0c96863)

* Added changelog fragment
…ile system provider paths (ansible#39203)

* Ansible.ModuleUtils.FileUtil - Add ability to test non file system provider paths (ansible#39200)


(cherry picked from commit b6afe69)

* Added changelog fragment
ansible#39192)

* adds index page for roadmaps to support internal links

* includes only roadmaps index page in TOC

(cherry picked from commit becc2a0)
Node port field is not populated on K8S pods, and it's certainely the most useful port to use in pod when we need to interact with ansible outside of the cluster
* Fix mysql-server install/upgrade on Ubuntu 16.04.
* Prevent service restart in docker_secret test.

(cherry picked from commit 996f9c2)
* Add note about the dangers of ANSIBLE_DEBUG

* Wording tweaks

(cherry picked from commit 7245671)
* fixes from 4b52a54
* leaves out the stub 2.6 porting guide
Exceptions need to use native strings.  We need to make sure we're
combining native strings with native strings.

(cherry picked from commit 0b64300)

Add changelog entry for winrm encoding fix

(cherry picked from commit a5e3396)
* ovirt_disks: Fix fail condition for LUN disk

Fixes: ansible#38661

* ovirt_host_networks: Fix removing of network attachments

* ovirt: Support removing unmanaged networks

* ovirt: FCP storage domains don't have to have target
Update test-module To use C.DEFAULT_LOCAL_TMP

(cherry picked from commit efdd92e)
* win_file: Handle [] in paths, fix touch in check mode (ansible#37901)

* win_file: Handle [] in paths, fix touch in check mode

* Fixed typo for p/invoke command

(cherry picked from commit 4b57fa9)

* Added changelog fragment for win_file special char fix

(cherry picked from commit 61bcf47)
…ue (ansible#39372)

* call diff callback also when task diff is true (ansible#39366)

fixes ansible#31129

(cherry picked from commit d76298b)

* Add changelog entry
still error if none of the paths provided was usable

fixes ansible#39044

(cherry picked from commit e4dbabb)
@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Apr 27, 2018
@bcoca bcoca closed this Apr 27, 2018
@bcoca bcoca removed this from To Do in 2.5.x blocker list Apr 27, 2018
@bcoca bcoca deleted the galaxy_bad_path_warn_39082 branch April 30, 2018 21:20
@ansible ansible locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet