Update ovirt_network.py #50653
Closed
Update ovirt_network.py #50653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's necessary to revert back to default MTU oVirt value. This can be achieved by using '0' as input value, which was missing in documentation. +label: docsite_pr
|
The test The test The test The test The test The test The test The test |
ansibot
added
affects_2.8
ansibot
removed
the
needs_triage
dagwieers
added
the
docsite_pr
| @@ -70,6 +70,7 @@ | |||
| mtu: | |||
| description: | |||
| - "Maximum transmission unit (MTU) of the network." | |||
| - "To set oVirt default MTU, use "0" as value" | |||
There was a problem hiding this comment.
Oh, it fails on syntax, can you please remove double quotes around "0"?
ansibot
added
the
stale_ci
Sometimes it's necessary to revert back to default MTU oVirt value. This can be achieved by using '0' as input value, which was missing in documentation. +label: docsite_pr
* csv of memory usage * Fix var * Configurable output file * Add cpu profiling * Valdiate the existence of cgroup files * Add guard to prevent exception when trying to reset max memory value * to_bytes/to_text and docs updates * Add support for CPU results * Just track the max, don't log all results, and then calculate max * Restore cgroup_memory_recap, and move new functionality into cgroup_perf_recap * Add pid count tracking, restructure to support more profilers * Add cli tool for graphing cgroup_perf_recap data * csv_output_dir is a path * Correct CALLBACK_NAME * Include uuid in csv data * fix linting errors * Bump version_added * Create helper funciton to create dict from list of keys, with callable default * Updated notes to include pids * Print a newline after each section * Plugin improvements * Add option to supporess recap display * Add default for output directory * Add option to dictate whether or not to write files * Add JSON-seq output option * s/uuid/task_uuid * Use bytes for paths * Increase polling interval length for pids/memory * Reduce instance attrs, change how we invoke profilers * Shorten some line lengths * Remove more instance attrs * Fix some typos * document directory creation, and catch exceptions * Enable per task file outputs, and filename customization * s/per_task_file/file_per_task/g
Seems like `self` is not necessary in the call args +label: docsite_pr
* Re-enable docker_network tests. * Basic cleanup of docker daemon. * Add docker CLI detection. * YAML notation.
…le#33043) * Included support to AIX group subsystems AIX systems has subsystems as services but also uses group subsystems. For example, spooler is a group subsystem to services qdaemon, writesrv, and lpd. This change enables the possibility to use also the group susbsystmes such as spooler, nfs, etc. When the service name is informed, first the module will check if the name is a subsystem, if not it will check if the name is a group subsystem and also it subsystems states. This change makes services more flexible with AIX systems. * Included test/legacy/aix_services.yml for tests As discussed on IRC ansible-devel channes, was include the legacy tests for further manual tests.
* Add ability for reboot module to work for AIX * changelog for AIX reboot support
* Add auth_timeout parameter when supported Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors. * Conditionally add auth_timeout to ssh.connect Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version. * Add changelog fragment
…0797) * Pluribus Networks switch setup module with unit test cases * Module error fix and pep8 standards error fix
"supported added" changed to "support added"
Changed "though" to "through"
fixed typo, note should be not
* Fixes ansible#29403: homebrew_cask: Add SUDO_ASKPASS to module.run_command * homebrew_cask: refactor sudo_password code * homebrew_cask: more refactoring * homebrew_cask: use %s instead of string addition
* Update nxos_aaa_server_host.py * remove host, username, and password
* Revert "Revert "openssl_csr: Allow to use cryptography as backend (ansible#50324)"" This reverts commit bbd2e31. * Remove more complicated selection copy'n'pasted from openssl_privatekey. * Add tests for backend selection. * Add openssl_csr test for arbitrary string commonName. * Allow to disable commonName -> SAN copying (fixes ansible#36690).
* Modified description in nmcli module doc The instructions for installing module's dependencies were incomplete. I copied the CentOS/Fedora part from the examples section, while I figured out myself the Debian/Ubuntu package names. +label: docsite_pr * Fix modified description in nmcli module doc * Fix modified description in nmcli module doc again * Fix modified description in nmcli module doc LB
Sometimes it's necessary to revert back to default MTU oVirt value. This can be achieved by using '0' as input value, which was missing in documentation. +label: docsite_pr
* Pass client to detect_usage function * Use new client argument in detect_usage function * Use option_minimal_versions * Add min_docker_api_version * Skip default since publish is always a list * Add min Docker API version to module requirements * Remove redundant keys() * Move detect_ipvX_address_usage out of __init__ * Check for mode presence in publish ports * Remove unused import * Use port.get(‘mode’) to check for falsy values * Update lib/ansible/modules/cloud/docker/docker_swarm_service.py Co-Authored-By: hannseman <hannes@5monkeys.se> * Add force_update to option_minimal_versions * Detect publish mode better * Add a trailing comma
…ble#50882) * Fix publish idempotency when mode is None * Add changelog fragment * Python 2.6 compat * Use self.publish * Check length of publish before comparing content * Sort publish lists before zipping * Enable publish tests * python3 compat * Don’t sort by mode as it is not safe * Document publish suboptions and add them to args * Add type to publish documentation * Add choices to publish argument_spec suboptions * Make tcp the default protocol * Make documentation reflect protocol default * Simplify setting mode * Remove redundant string quoting * Test order of publish * Add comment about publish change detection
…atch-1 Conflicts: lib/ansible/modules/cloud/ovirt/ovirt_network.py
|
@knumskull this PR contains the following merge commits: Please rebase your branch to remove these commits. |
|
@knumskull This PR contains |
|
@knumskull This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
ansibot
added
merge_commit
|
Build succeeded (third-party-check pipeline).
|
dagwieers
added
ovirt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's necessary to revert back to default MTU oVirt value. This can be achieved by using '0' as input value, which was missing in documentation.
+label: docsite_pr
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION