-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement extra sidecar support #1236
base: devel
Are you sure you want to change the base?
Conversation
@Yomanz Could you add some documentation in the README.md on how to use this in this PR? In that section, could you also add some potential use cases? Otherwise, I think this looks good. Feel free to join our next community meeting to share this with others in the community! |
I will add some documentation, yeah. |
Hey @Yomanz , are you still interested in adding a README.md entry here? |
Are there any update with this feature? We were looking for the same feature. It will be good if it can be implemented |
@WenboDu1228 would you be interested in adding docs for this feature with some use case(s)? Then we can consider this feature complete and merge (code looks good and works as is). It could be on a separate PR. |
Co-authored-by: pc-quiknode <126496711+pc-quiknode@users.noreply.github.com>
Hi @Yomanz thanks for your contribution and welcome to the AWX community. Recently there's been some big changes in the AWX operator and AWX, we split up the task and web deployment for this feature to go forward can you implement the sidecar for both web and task container following how we handled the |
What is the delay with getting this merged and publishing a new release with this feature? I and several others need this functionality. Can we please dispense with the foot-dragging and get it done? |
I can look into doing this 👍 |
Hey @TheRealHaoLiu and @Yomanz, I am willing to takeover if it is ok with you. I can continue on @Yomanz 's work and make the changes for the separation between web and task pods. |
Yeah crack on that'd be great, I did plan to finish this but I just ran out of time for it unfortunately. |
If we implement and overrides feature like describe in #479, that would allow for injection sidecar containers as well. |
SUMMARY
This PR adds a new property that allows you to specify sidecars to add to the AWX pod as blocks within the config.
Fixes #1235
ISSUE TYPE
ADDITIONAL INFORMATION
This is useful for people who might need to add a VPN or other extra functionality to awx while using the awx-operator.