Enable setting a list of image_pull_secrets #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelee
reviewed
Jan 20, 2022
MaximilianMeister
force-pushed
the
multiple_image_pull_secrets
branch
2 times, most recently
from
0a3330f
to
360fb88
Compare
When there are e.g. multiple authenticated container registries used we need to be able to add multiple imagePullSecrets to the k8s resource
MaximilianMeister
force-pushed
the
multiple_image_pull_secrets
branch
from
360fb88
to
c48c406
Compare
Merged
|
Sorry for the long wait @MaximilianMeister, thank you for your patience. There were a couple conflicts because of other changes recently merged. I picked your commit into a new PR and fixes the conflicts. I will have this merged before EOD. Thank you for contributing this and for making the suggested changes to make it backwards compatible! |
|
This change has now merged in PR 860. Thank you! |
|
@rooftopcellist thanks for picking this up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are e.g. multiple authenticated container registries used
we need to be able to add multiple imagePullSecrets to the k8s resource
NOTE: I haven't run any tests so far to confirm that it works