Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show job traceback stdout and error details #8726

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Show job traceback stdout and error details #8726

merged 3 commits into from
Feb 3, 2021

Conversation

jakemcdermott
Copy link
Contributor

SUMMARY

For #8709

  • Render result tracebacks as stdout
  • Display status explanation message when available
ADDITIONAL INFORMATION

job_traceback

@ryanpetrello
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nixocio nixocio mentioned this pull request Dec 1, 2020
Closed
@AlanCoding
Copy link
Member

Looks great! thanks

@unlikelyzero
Copy link

@jakemcdermott we're going to take our first look at this on wednesday

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero
Copy link

@jakemcdermott @AlanCoding is ERROR the only state which includes a status explanation? Should we test FAILED state as well?

@unlikelyzero
Copy link

covered in job-template-tabs and job-result-output

@jakemcdermott jakemcdermott marked this pull request as draft December 18, 2020 19:40
@jakemcdermott

This comment has been minimized.

Sign in to view
@unlikelyzero unlikelyzero added state:needs_test type:feature prioritized on a feature board and removed type:enhancement labels Jan 4, 2021
@unlikelyzero
Copy link

#8995 has some additional details on reproduction steps

@fosterseth fosterseth mentioned this pull request Jan 22, 2021
Merged
@jakemcdermott jakemcdermott marked this pull request as ready for review February 1, 2021 03:17
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jakemcdermott jakemcdermott mentioned this pull request Feb 2, 2021
Closed
@one-t
Copy link
Contributor

one-t commented Feb 3, 2021

Stubs added here: https://github.com/ansible/tower-qa/pull/5938

I've tested this with Project syncs, Inventory Syncs, Job Template runs and it is working as expected now.

@one-t one-t added the mergeit label Feb 3, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 54d63ee into ansible:devel Feb 3, 2021
@unlikelyzero unlikelyzero mentioned this pull request Feb 14, 2021
Closed
@jakemcdermott jakemcdermott mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSCorey AlexSCorey AlexSCorey left review comments

@AlanCoding AlanCoding AlanCoding left review comments

@one-t one-t one-t approved these changes

Assignees
No one assigned
Labels
component:ui type:feature prioritized on a feature board
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jakemcdermott @ryanpetrello @AlanCoding @unlikelyzero @one-t @AlexSCorey @tiagodread