MAINT: Update dependencies with ranges #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4369 +/- ##
==========================================
- Coverage 81.60% 76.67% -4.93%
==========================================
Files 107 107
Lines 52489 52489
==========================================
- Hits 42834 40248 -2586
- Misses 9655 12241 +2586 |
SMoraisAnsys
force-pushed
the
maint/update_dependencies_with_ranges
branch
from
1f71f49
to
c885d0a
Compare
Wiz Scan Summary
|
MaxJPRey
reviewed
Mar 20, 2024
Samuelopez-ansys
approved these changes
Mar 20, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way we handle dependencies is too "tight" and can easily lead to conflicts when installing pyaedt with other projects. This is even more problematic as it happens with other ansys projects, e.g. pyedb, pyaedt toolkits, ...
This PR proposes to use ranges to specify a wider compatibility of dependencies.
This changes have been tested in https://github.com/ansys/pyaedt/actions/runs/8345060900 where used python 3.7, 3.8, 3.9, 3.10 and 3.11, installed pyaedt with test dependencies and run the tests. Except for EMIT that is not available in Python3.7 (explaining the
skipifdecorator) every tests were passing correctly for every versions !