Update jupyter, move to ghcr.io and simplify CI #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
plule-ansys
commented
Oct 20, 2021
plule-ansys
commented
- Update jupyter-hub to its latest version and switch to the ":hub-" base-notebook tag: Jupyter lab will complain on version difference between jupyterlab and the base images
- Update all the conda/pip/labextension dependencies
- Reenable the cadquery notebook that was fixed by these updates. Still need the :master notation for cadquery though.
- Move to ghcr.io and simplify the CI accordingly (image name = repo name)
akaszynski
reviewed
Oct 20, 2021
| @@ -1,6 +1,6 @@ | |||
| FROM jupyter/base-notebook:python-3.8.8 | |||
| FROM jupyter/base-notebook:hub-1.4.2 | |||
There was a problem hiding this comment.
Guess 3.8 isn't the latest anyway. Between the python-3.9 and hub images, I'm not seeing any difference in the docker layers, so either one works.
There was a problem hiding this comment.
@akaszynski ah yep I did this change because I had warnings of version difference between the jupyter hub base image and the version of the helm chart, so I thought tagging by hub version was more significant here
akaszynski
reviewed
Oct 20, 2021
akaszynski
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.