test: expand coverage and add bug fix test - #2103
Merged
Merged
Conversation
…thub.com/ansys/pyansys-geometry into test/bug_fix_test_plus_expanded_coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2103 +/- ##
==========================================
+ Coverage 93.50% 93.68% +0.18%
==========================================
Files 138 138
Lines 10156 10156
==========================================
+ Hits 9496 9515 +19
+ Misses 660 641 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RyanJWard
marked this pull request as ready for review
July 11, 2025 17:12
RobPasMue
reviewed
Jul 14, 2025
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Apart from my comment regarding the API to use, all good! Thanks @RyanJWard
RobPasMue
approved these changes
Jul 14, 2025
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tests for product_instance.py and launcher.py using monkeypatch to avoid launching anything.
Also added a bug fix test for a server side change dealing with inserted file id's
Checklist
feat: extrude circle to cylinder)