-
Notifications
You must be signed in to change notification settings - Fork 20
test: expand coverage and add bug fix test #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…thub.com/ansys/pyansys-geometry into test/bug_fix_test_plus_expanded_coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2103 +/- ##
==========================================
+ Coverage 93.50% 93.68% +0.18%
==========================================
Files 138 138
Lines 10156 10156
==========================================
+ Hits 9496 9515 +19
+ Misses 660 641 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comment regarding the API to use, all good! Thanks @RyanJWard
Description
Added tests for product_instance.py and launcher.py using monkeypatch to avoid launching anything.
Also added a bug fix test for a server side change dealing with inserted file id's
Checklist
feat: extrude circle to cylinder
)