Skip to content

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jul 11, 2025

Description

Added tests for product_instance.py and launcher.py using monkeypatch to avoid launching anything.
Also added a bug fix test for a server side change dealing with inserted file id's

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Jul 11, 2025
@github-actions github-actions bot added the testing Anything related to tests label Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (bfa184d) to head (f42d5b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
+ Coverage   93.50%   93.68%   +0.18%     
==========================================
  Files         138      138              
  Lines       10156    10156              
==========================================
+ Hits         9496     9515      +19     
+ Misses        660      641      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanJWard RyanJWard marked this pull request as ready for review July 11, 2025 17:12
@RyanJWard RyanJWard requested a review from a team as a code owner July 11, 2025 17:12
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment regarding the API to use, all good! Thanks @RyanJWard

@RobPasMue RobPasMue merged commit f82160d into main Jul 14, 2025
77 of 79 checks passed
@RobPasMue RobPasMue deleted the test/bug_fix_test_plus_expanded_coverage branch July 14, 2025 12:09
@RobPasMue RobPasMue linked an issue Jul 14, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After calling design.insert_file, design instance gets corrupted
3 participants