Skip to content

Conversation

RobPasMue
Copy link
Member

As title says

@github-actions github-actions bot added the maintenance Generic maintenance related label Jun 15, 2023
@RobPasMue
Copy link
Member Author

RobPasMue commented Jun 15, 2023

  • Docker containers can only be run on Linux runners so removing Windows testing.
  • Also, uploading Docker container logs to artifacts

@RobPasMue
Copy link
Member Author

Attempting to compare output files, which are located inside the server... this is what is causing the workflow to fail. It is needed to provide a "download" API that will allow end users to extract the files from the container.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 19, 2023
@zhangzhanqun zhangzhanqun requested a review from wenhuiuy June 19, 2023 05:53
Copy link
Member Author

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@RobPasMue RobPasMue merged commit c65f3b1 into main Jun 19, 2023
@RobPasMue RobPasMue deleted the cicd/docker branch June 19, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants