Skip to content

Conversation

kanthadya
Copy link
Contributor

Landing page updated

@kanthadya kanthadya requested a review from a team as a code owner July 4, 2023 09:44
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 4, 2023
@PipKat
Copy link
Member

PipKat commented Jul 5, 2023

@kanthadya Roberto has requested that I do the overall doc review for public release of this repo. I'd like to see this PR merged before starting this. I think the biggest question here is that in GitHub, I see three pydyna repositories: pydyna, pydyna-keywords, and pydyna-pre. I assume that pydyna is what you are referring to in this PR as solver--but that doesn't match the package name. Also, do we want it to be PyDYNA because the Ansys product name is LS-DYNA? Before I can do an edit, we need to determine what names to use. Once I'm clear on this, I can do the overall edit. (Also--will all three of these packages be made pubic--or just pydyna and pydyna-pre?

@kanthadya
Copy link
Contributor Author

kanthadya commented Jul 5, 2023 via email

@PipKat
Copy link
Member

PipKat commented Jul 5, 2023

@kanthadya
I'd rather get this PR merged. I can do the renaming throughout the files as I do the overall doc review. Thanks, though, for offering! If there is one package, how do we distinguish pre and solver? Are the modules of the pydyna package?

@RobPasMue RobPasMue enabled auto-merge (squash) July 7, 2023 06:14
@RobPasMue RobPasMue merged commit 161bc29 into main Jul 7, 2023
@RobPasMue RobPasMue deleted the doc2 branch July 7, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants