Skip to content

Conversation

rokamoto26
Copy link
Contributor

…rt_ids

fix: change get_polydata and extract_solids to display solid elements correctly
fix: update test_plotter.py according to the update of deck_plotter.py

…rt_ids

fix: change get_polydata and extract_solids to display solid elements correctly
fix: update test_plotter.py according to the update of deck_plotter.py
@rokamoto26 rokamoto26 requested a review from a team as a code owner August 13, 2025 06:09
@github-actions github-actions bot added enhancement General improvements to existing features testing Anything related to testing labels Aug 13, 2025
@koubaa
Copy link
Collaborator

koubaa commented Aug 13, 2025

Thanks for the contribution, the deck plotter is indeed under-developed. Could you please fix the failing test case?

@rokamoto26
Copy link
Contributor Author

HI @koubaa, I fixed the test case and all checks have passed. Could you review the updated code?

@koubaa
Copy link
Collaborator

koubaa commented Aug 15, 2025

@rokamoto26 I downloaded the html documentation from the documentation build check, and some of the images look different. For example in your branch the beer can example plot looks like this:

image

See the current doc image here:
https://dyna.docs.pyansys.com/version/stable/examples/Buckling_Beer_Can/plot_beercan.html#view-the-model

@rokamoto26
Copy link
Contributor Author

Hi @koubaa, thank you for reviewing!

This is just the part ID being plotted. Since the part ID is stored as a scalar value, it is plotted according to the PyVista default behavior.
https://docs.pyvista.org/api/plotting/_autosummary/pyvista.plotter.add_mesh#pyvista.Plotter.add_mesh

It is possible to control this behavior in deck_plotter, but if it differs from the PyVista specification, it may cause confusion for users.

@koubaa
Copy link
Collaborator

koubaa commented Aug 20, 2025

In that case, the display of the part ID should be opt-in, not default.

@rokamoto26
Copy link
Contributor Author

@koubaa Thank you for your comment. I changed plot behavior. Could you review again?
Note that the images of the Taylor Bar Impact and John Reid pipe examples have changed, as the previous ones were incorrect.

@koubaa
Copy link
Collaborator

koubaa commented Aug 22, 2025

I verified the new visualizations, and they are a clear improvement. Thank you for your contribution!

@koubaa koubaa merged commit 5f86b94 into main Aug 22, 2025
29 checks passed
@koubaa koubaa deleted the feat/update_deck_plotter branch August 22, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants