-
Notifications
You must be signed in to change notification settings - Fork 18
feat: enhance facet extraction functions to return element_ids and pa… #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rt_ids fix: change get_polydata and extract_solids to display solid elements correctly fix: update test_plotter.py according to the update of deck_plotter.py
Thanks for the contribution, the deck plotter is indeed under-developed. Could you please fix the failing test case? |
HI @koubaa, I fixed the test case and all checks have passed. Could you review the updated code? |
@rokamoto26 I downloaded the html documentation from the documentation build check, and some of the images look different. For example in your branch the beer can example plot looks like this: ![]() See the current doc image here: |
Hi @koubaa, thank you for reviewing! This is just the part ID being plotted. Since the part ID is stored as a scalar value, it is plotted according to the PyVista default behavior. It is possible to control this behavior in deck_plotter, but if it differs from the PyVista specification, it may cause confusion for users. |
In that case, the display of the part ID should be opt-in, not default. |
…olor or scalar keyword arguments in plot_deck
…to feat/update_deck_plotter
@koubaa Thank you for your comment. I changed plot behavior. Could you review again? |
I verified the new visualizations, and they are a clear improvement. Thank you for your contribution! |
…rt_ids
fix: change get_polydata and extract_solids to display solid elements correctly
fix: update test_plotter.py according to the update of deck_plotter.py